commit da30c05a101318828faf559ea66bc6ce1f638bc8
from: Stefan Sperling <stsp@stsp.name>
date: Fri May 24 14:12:39 2024 UTC

remove a redundant bounds check which gets elided by clang

found by + ok op@

commit - 0fa332b53c81ad34f6e60bad94ce41e14d0bffab
commit + da30c05a101318828faf559ea66bc6ce1f638bc8
blob - 54605335e3cdf190211ea780d1041ad6a31647f0
blob + 1aa0ceaebb61ff5f5d563b41111c0e63ce2a9830
--- lib/pack_index.c
+++ lib/pack_index.c
@@ -245,12 +245,6 @@ read_packed_object(struct got_pack *pack, struct got_i
 				err = got_error(GOT_ERR_BAD_PACKFILE);
 				break;
 			}
-			if (mapoff + SHA1_DIGEST_LENGTH > SIZE_MAX) {
-				err = got_error_fmt(GOT_ERR_RANGE,
-				    "mapoff %lld would overflow size_t",
-				    (long long)mapoff + SHA1_DIGEST_LENGTH);
-				break;
-			}
 			memcpy(obj->delta.ref.ref_id.sha1, pack->map + mapoff,
 			    SHA1_DIGEST_LENGTH);
 			obj->crc = crc32(obj->crc, pack->map + mapoff,